[PATCH] D58881: [Transform] Improve fold of sadd.with.overflow

[Simonas Kazlauskas via Phabricator via llvm-commits]

nagisa added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:2044
+    // - Opposite signs with |C2|>|C1| can be folded to a single overflow call
+    // - Opposite signs with |C2|<=|C1| can be folded to a single nsw call
+    //
----------------
This last case can also be folded into an `overflow` call. While not optimal, it "feels" to me that we better do that, rather than skipping this case entirely, if just for now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58881/new/

https://reviews.llvm.org/D58881