[PATCH] D58434: AddressSanitizer: 64-bit SPARC/Linux port

[Brad Smith via Phabricator via llvm-commits]

brad marked an inline comment as done.
brad added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_allocator.h:142
+# elif defined(__sparc__)
+const uptr kAllocatorSpace = ~(uptr)0;
+const uptr kAllocatorSize  =  0x20000000000ULL;  // 2T.
----------------
krytarowski wrote:
> vitalybuka wrote:
> > @krytarowski I assumed that worked on Solaris, probably only x86
> > 
> I'm not sure about Linux, but on NetBSD we need to use `defined(__sparc64__)` (or `&& defined(_LP64)`) as `defined(__sparc__)` catches both ISA variations 32-bit and 64-bit.
> 
> I can see that we only test x86 32-bit and 64-bit in our releng setup. SPARC 32-bit and 64-bit is verified just with UBSan.
Regarding `__sparc__` this is also the case on OpenBSD/sparc64.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58434/new/

https://reviews.llvm.org/D58434