[PATCH] D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI

Sat Mar 2 07:54:47 PST 2019

Hahnfeld requested review of this revision.
Hahnfeld added a comment.

In D58837#1416063 <https://reviews.llvm.org/D58837#1416063>, @MaskRay wrote:

> In D58837#1416042 <https://reviews.llvm.org/D58837#1416042>, @Hahnfeld wrote:
>
> > I think we could just add a `break` and handle that case in the generic `switch` below. But I think you're right, the current patch would break for Hexagon, MIPS and PPC64. I tested with assertions enabled, but maybe there is no test case exercising this code path?
>
>
> Yes. For this patch using `break;` should be good enough. There may not be tests for such corrupted binaries.

I've added one which would have asserted in the previous version of this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58837/new/

https://reviews.llvm.org/D58837