[PATCH] D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 23:53:15 PST 2019


MaskRay added a comment.

`getDynamicTagAsString` is used by `llvm-objdump` and it'd be better if `llvm-objdump` can parse some malformed binaries (with bad `.dynsym`). If the tag is unknown, returning a stringified `Type` may make sense.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58837/new/

https://reviews.llvm.org/D58837





More information about the llvm-commits mailing list