[PATCH] D58837: [ELF] Fix GCC8 warnings about "fall through", NFCI

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: llvm/lib/Object/ELF.cpp:441
     }
+    llvm_unreachable("Previous switch() should have return'ed!");
 
----------------
Looks like in LLVM something like "Invalid dynamic tag type" is more common error message to pass to llvm_unreachable.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86ELFObjectWriter.cpp:116
     }
+    llvm_unreachable("Previous switch() should have return'ed!");
   case MCSymbolRefExpr::VK_GOT:
----------------
Ditto -- I'd pass "Invalid relocation type".


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58837/new/

https://reviews.llvm.org/D58837