[PATCH] D58851: [SCEV] Remove undef check for SCEVConstant (NFC)
    Florian Hahn via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Mar  1 14:53:01 PST 2019
    
    
  
fhahn created this revision.
fhahn added reviewers: mkazantsev, sanjoy.
Herald added subscribers: javed.absar, hiraditya.
Herald added a project: LLVM.
The value stored in SCEVConstant is of type ConstantInt*, which can
never be UndefValue. So we should never hit that code.
Repository:
  rG LLVM Github Monorepo
https://reviews.llvm.org/D58851
Files:
  llvm/lib/Analysis/ScalarEvolution.cpp
Index: llvm/lib/Analysis/ScalarEvolution.cpp
===================================================================
--- llvm/lib/Analysis/ScalarEvolution.cpp
+++ llvm/lib/Analysis/ScalarEvolution.cpp
@@ -10824,8 +10824,6 @@
   return SCEVExprContains(S, [](const SCEV *S) {
     if (const auto *SU = dyn_cast<SCEVUnknown>(S))
       return isa<UndefValue>(SU->getValue());
-    else if (const auto *SC = dyn_cast<SCEVConstant>(S))
-      return isa<UndefValue>(SC->getValue());
     return false;
   });
 }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58851.188980.patch
Type: text/x-patch
Size: 504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190301/638d624b/attachment.bin>
    
    
More information about the llvm-commits
mailing list