[PATCH] D58848: [DebugInfo] follow up for "add SectionedAddress to DebugInfo interfaces"

[Alexey Lapshin via Phabricator via llvm-commits]

avl created this revision.
avl added reviewers: dblaikie, grimar, delcypher.
Herald added subscribers: rupprecht, hiraditya.
Herald added a project: LLVM.

This patch fixes buildbot failures after https://reviews.llvm.org/D58194.

[Symbolizer] Add getModuleSectionIndexForAddress() helper routine

      
    The https://reviews.llvm.org/D58194 patch changed symbolizer interface.
  Particularily it requires not only Address but SectionIndex also.
  Note object::SectionedAddress parameter:
      
    Expected<DILineInfo> symbolizeCode(const std::string &ModuleName,
                                     object::SectionedAddress ModuleOffset,
                                     StringRef DWPName = "");
      
    Until all places patched for the correct SectionIndex there were created
  helper function which preserves existing behavior and allow to set
  SectionIndex.
      
  llvm-symbolizer.c:getModuleSectionIndexForAddress()
      
  That function did not take into account that ModuleName on some platforms
  (Darwin) could differ from the binary name. This fix moves
  getModuleSectionIndexForAddress() into Symbolize.h/cpp and reuse already
  existing handling for module name to properly parse binary and architecture
  names. That cures Darwin/haswell-symbolication.cc.
  
  [IntelJITEvents] set proper SectionIndex instead of Undefined value. That cures
  several lit tests.


https://reviews.llvm.org/D58848

Files:
  llvm/include/llvm/DebugInfo/Symbolize/Symbolize.h
  llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
  llvm/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp
  llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58848.188970.patch
Type: text/x-patch
Size: 8999 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190301/78f245a3/attachment.bin>