[PATCH] D58141: [tblgen] Track CodeInit origins when possible

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 11:48:34 PST 2019


paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

Better error-reporting sounds like a net win to me. LGTM aside from spelling nit.



================
Comment at: lib/TableGen/Record.cpp:525
+
+  // Location tracking prevents us from de-duping CodeInit's as we're never
+  // called with the same string and same location twice. However, we can at
----------------
s/CodeInit's/CodeInits/


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58141/new/

https://reviews.llvm.org/D58141





More information about the llvm-commits mailing list