[llvm] r355216 - [PGO] Remove the default parameter in ProfileSummary API. NFC

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 10:36:24 PST 2019


Author: xur
Date: Fri Mar  1 10:36:24 2019
New Revision: 355216

URL: http://llvm.org/viewvc/llvm-project?rev=355216&view=rev
Log:
[PGO] Remove the default parameter in ProfileSummary API. NFC

Remove the default parameter in setProfileSummary() and getSummary().
This is a follow-up of r355131.

Modified:
    llvm/trunk/include/llvm/IR/Module.h
    llvm/trunk/include/llvm/ProfileData/InstrProfReader.h

Modified: llvm/trunk/include/llvm/IR/Module.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Module.h?rev=355216&r1=355215&r2=355216&view=diff
==============================================================================
--- llvm/trunk/include/llvm/IR/Module.h (original)
+++ llvm/trunk/include/llvm/IR/Module.h Fri Mar  1 10:36:24 2019
@@ -869,9 +869,7 @@ public:
   /// @{
 
   /// Attach profile summary metadata to this module.
-  // TODO: Remove the default paramter.
-  void setProfileSummary(Metadata *M,
-                         ProfileSummary::Kind Kind = ProfileSummary::PSK_Instr);
+  void setProfileSummary(Metadata *M, ProfileSummary::Kind Kind);
 
   /// Returns profile summary metadata. When IsCS is true, use the context
   /// sensitive profile summary.

Modified: llvm/trunk/include/llvm/ProfileData/InstrProfReader.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ProfileData/InstrProfReader.h?rev=355216&r1=355215&r2=355216&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ProfileData/InstrProfReader.h (original)
+++ llvm/trunk/include/llvm/ProfileData/InstrProfReader.h Fri Mar  1 10:36:24 2019
@@ -501,8 +501,7 @@ public:
 
   /// Return the profile summary.
   /// \c UseCS indicates whether to use the context-sensitive summary.
-  // TODO: removed the defualt parameter.
-  ProfileSummary &getSummary(bool UseCS = false) {
+  ProfileSummary &getSummary(bool UseCS) {
     if (UseCS) {
       assert(CS_Summary && "No context sensitive summary");
       return *(CS_Summary.get());




More information about the llvm-commits mailing list