[PATCH] D58726: [DebugInfo][Docs] Explicitly document how dbg.value intrinsics are interpreted in optimized code

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

A few wording notes.  Haven't worked through the examples yet.



================
Comment at: docs/SourceLevelDebugging.rst:409
+  the variable's value changes.
+* Operands can be constant valued, indicating the variable is assigned a
+  constant value.
----------------
"constant valued"?  maybe "Operands can be constants, ..."?


================
Comment at: docs/SourceLevelDebugging.rst:433
+present ``optimized out`` to the developer. Withholding these potentially stale
+variable valuations from the developer diminishes the amount of available debug
+information, but increases the reliability of the remaining information.
----------------
valuations -> values


================
Comment at: docs/SourceLevelDebugging.rst:479
+
+What dbg.value intrinsics should be placed to represent the original variable
+locations in this code? Unfortunately the the second, third and fourth
----------------
I'm happy to let you use `dbg.value` as a shorthand in most places, but when you specifically call them "intrinsics" I think you should use the full name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58726/new/

https://reviews.llvm.org/D58726