[PATCH] D58809: [LICM] Infer proper alignment from loads during scalar promotion

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 09:56:50 PST 2019


asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

This LGTM.



================
Comment at: lib/Transforms/Scalar/LICM.cpp:1934
+        // sufficient alignment at the target location.  Proving it guaranteed
+        // to execute does as well.  Thus we can thus increase our guaranteed
+        // alignment as well. 
----------------
Nit: delete a "thus".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58809/new/

https://reviews.llvm.org/D58809





More information about the llvm-commits mailing list