[llvm] r355205 - Hide two unused debugging methods, NFCI.
Jonas Hahnfeld via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 1 09:15:21 PST 2019
Author: hahnfeld
Date: Fri Mar 1 09:15:21 2019
New Revision: 355205
URL: http://llvm.org/viewvc/llvm-project?rev=355205&view=rev
Log:
Hide two unused debugging methods, NFCI.
GCC correctly moans that PlainCFGBuilder::isExternalDef(llvm::Value*) and
StackSafetyDataFlowAnalysis::verifyFixedPoint() are defined but not used
in Release builds. Hide them behind 'ifndef NDEBUG'.
Modified:
llvm/trunk/lib/Analysis/StackSafetyAnalysis.cpp
llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp
Modified: llvm/trunk/lib/Analysis/StackSafetyAnalysis.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/StackSafetyAnalysis.cpp?rev=355205&r1=355204&r2=355205&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/StackSafetyAnalysis.cpp (original)
+++ llvm/trunk/lib/Analysis/StackSafetyAnalysis.cpp Fri Mar 1 09:15:21 2019
@@ -415,7 +415,9 @@ class StackSafetyDataFlowAnalysis {
updateOneNode(F.first, F.second);
}
void runDataFlow();
+#ifndef NDEBUG
void verifyFixedPoint();
+#endif
public:
StackSafetyDataFlowAnalysis(
@@ -526,11 +528,13 @@ void StackSafetyDataFlowAnalysis::runDat
}
}
+#ifndef NDEBUG
void StackSafetyDataFlowAnalysis::verifyFixedPoint() {
WorkList.clear();
updateAllNodes();
assert(WorkList.empty());
}
+#endif
StackSafetyGlobalInfo StackSafetyDataFlowAnalysis::run() {
runDataFlow();
Modified: llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp?rev=355205&r1=355204&r2=355205&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp (original)
+++ llvm/trunk/lib/Transforms/Vectorize/VPlanHCFGBuilder.cpp Fri Mar 1 09:15:21 2019
@@ -63,7 +63,9 @@ private:
void setVPBBPredsFromBB(VPBasicBlock *VPBB, BasicBlock *BB);
void fixPhiNodes();
VPBasicBlock *getOrCreateVPBB(BasicBlock *BB);
+#ifndef NDEBUG
bool isExternalDef(Value *Val);
+#endif
VPValue *getOrCreateVPOperand(Value *IRVal);
void createVPInstructionsForVPBB(VPBasicBlock *VPBB, BasicBlock *BB);
@@ -118,6 +120,7 @@ VPBasicBlock *PlainCFGBuilder::getOrCrea
return VPBB;
}
+#ifndef NDEBUG
// Return true if \p Val is considered an external definition. An external
// definition is either:
// 1. A Value that is not an Instruction. This will be refined in the future.
@@ -153,6 +156,7 @@ bool PlainCFGBuilder::isExternalDef(Valu
// Check whether Instruction definition is in loop body.
return !TheLoop->contains(Inst);
}
+#endif
// Create a new VPValue or retrieve an existing one for the Instruction's
// operand \p IRVal. This function must only be used to create/retrieve VPValues
More information about the llvm-commits
mailing list