[PATCH] D58831: [DebugInfo] Ignore bitcasts when lowering stack arg dbg.values
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 1 08:19:13 PST 2019
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5309
// Check if frame index is available.
- if (LoadSDNode *LNode = dyn_cast<LoadSDNode>(N.getNode()))
+ SDValue LCandidate = peekThroughBitcasts(N);
+ if (LoadSDNode *LNode = dyn_cast<LoadSDNode>(LCandidate.getNode()))
----------------
LGTM; is this the most general place where to do this, or could we do this higher up in the function and catch more cases?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58831/new/
https://reviews.llvm.org/D58831
More information about the llvm-commits
mailing list