[PATCH] D56286: [OPENMP] Deal with additional store inserted by Clang under -fno-PIC for PowerPC.

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 07:59:51 PST 2019


stefanp added a comment.

The reason why we don't clean up that extra store on no-PIC is because we run a couple of extra passes for PIC for PowerPC. 
It is this code:

  // FIXME: We probably don't need to run these for -fPIE.
  if (getPPCTargetMachine().isPositionIndependent()) {
    // FIXME: LiveVariables should not be necessary here!
    // PPCTLSDynamicCallPass uses LiveIntervals which previously dependent on
    // LiveVariables. This (unnecessary) dependency has been removed now,
    // however a stage-2 clang build fails without LiveVariables computed here.
    addPass(&LiveVariablesID, false);
    addPass(createPPCTLSDynamicCallPass());
  }

Those extra passes clean up the extra store. 
If I remember correctly this is only really an issue at -O0. At higher opts other passes clean up stores like that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56286/new/

https://reviews.llvm.org/D56286





More information about the llvm-commits mailing list