[PATCH] D58672: [X86] Avoid codegen changes when DBG_VALUE appears between lowered selects

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 07:49:11 PST 2019


jmorse updated this revision to Diff 188922.
jmorse added a comment.

Incorporate feedback: use skipDebugInstructionsForward for better readability, iterate forwards when sinking DBG_VALUEs.

(We still have to juggle iterators when sinking the DBG_VALUEs as I believe the current one is invalidated when you call removeFromParent()).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58672/new/

https://reviews.llvm.org/D58672

Files:
  lib/Target/X86/X86ISelLowering.cpp
  test/CodeGen/X86/pseudo_cmov_lower2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58672.188922.patch
Type: text/x-patch
Size: 4483 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190301/d42d084a/attachment.bin>


More information about the llvm-commits mailing list