[PATCH] D58817: Add wildcard support to all update_*_test_checks.py scripts (PR37500)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 04:53:23 PST 2019


RKSimon marked an inline comment as done.
RKSimon added inline comments.


================
Comment at: utils/update_mir_test_checks.py:429
+    test_paths = [test for pattern in args.tests for test in glob.glob(pattern)]
+    for test in test_path:
         try:
----------------
gbedwell wrote:
> typo?  test_path*s*
cheers - I tested llc/opt/analyze variants but hadn't mir as I hit some python3 issues ("bytes-like object is required, not 'str'"") that I hadn't tracked down...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58817/new/

https://reviews.llvm.org/D58817





More information about the llvm-commits mailing list