[PATCH] D58533: [hwasan, asan] Intercept vfork.

Jonas Hahnfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 1 03:27:17 PST 2019


Hahnfeld marked an inline comment as done.
Hahnfeld added inline comments.


================
Comment at: lib/hwasan/hwasan.cpp:491
+  if (top == 0 || bottom == 0 || sp < bottom || sp >= top ||
+      sp - bottom > kMaxExpectedCleanupSize) {
+    Report(
----------------
eugenis wrote:
> Hahnfeld wrote:
> > This fails `test/hwasan/TestCases/Linux/vfork.c` for me with `ulimit -s unlimited` (or anything larger than `ulimit -s 131072`). What's the best solution here?
> Thanks for bringing this up!
> I've removed the failing check in https://reviews.llvm.org/rL355137
Thanks for your fast fix, it also works for me now :-)


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58533/new/

https://reviews.llvm.org/D58533





More information about the llvm-commits mailing list