[PATCH] D58572: [Support] allow -stats/-time-passes reporting into a custom stream

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 22:34:59 PST 2019


chandlerc added a comment.

I do generally feel like it would be a useful and generically good direction to support the timing system having a pre-bound output stream so that it completely avoids the flag-based info output stream we currently use. It moves everything into a proper API instead of a flags based system that seems inherently hostile to more advanced users.

It also seems good to separate this at the *pass manager* level with a specifically bound pass because it is timing passes.

Statistics are, IMO, a separate question. There, I would suggest that the correct way to have useful parallel access to statistics is to follow-through on a long-standing idea of making statistics be owned by the `LLVMContext`. But unsure how necessary this is... I thought our statistics were already atomic updated. So maybe it would be enough to just have a single stream for those?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58572/new/

https://reviews.llvm.org/D58572





More information about the llvm-commits mailing list