[PATCH] D58808: ELF: Extract a non-ELFT base class for VersionNeedSection.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 19:45:46 PST 2019


ruiu added a comment.

I wonder if we can just get rid of ELFT from the class. At runtime we know endianess and word width, so in theory we can create a version table without ELFT. I'm not totally sure if this makes things easier to handle, but many classes are template with ELFT because they transitively use a ELFT-templated class. So removing ELFT from one class might allow us remove ELFT from more classes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58808/new/

https://reviews.llvm.org/D58808





More information about the llvm-commits mailing list