[PATCH] D58804: AMDGPU/GlobalISel: Implement select for 32-bit G_ADD
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 28 18:11:35 PST 2019
arsenm added inline comments.
================
Comment at: test/CodeGen/AMDGPU/GlobalISel/inst-select-add.mir:1
+# RUN: llc -march=amdgcn -run-pass=instruction-select -verify-machineinstrs -global-isel %s -o - | FileCheck %s -check-prefixes=GCN
+
----------------
I’ve just been generating all of the global isel test checks
================
Comment at: test/CodeGen/AMDGPU/GlobalISel/inst-select-add.mir:4
+---
+name: add
+legalized: true
----------------
Can you include the type in the name
================
Comment at: test/CodeGen/AMDGPU/GlobalISel/inst-select-add.mir:40
+
+...
----------------
64-bit scalar at least looks like is already handled that should have a test here
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58804/new/
https://reviews.llvm.org/D58804
More information about the llvm-commits
mailing list