[PATCH] D57530: Order File Instrumentation: dump the data in compiler-rt

[Manman Ren via Phabricator via llvm-commits]

manmanren marked 2 inline comments as done.
manmanren added a comment.

Thanks!

Manman



================
Comment at: lib/profile/InstrProfilingFile.c:116
+  unsigned Len = fwrite(DataStart, sizeof(uint32_t), INSTR_ORDER_FILE_BUFFER_SIZE, File);
+#if 0
+#if 0
----------------
davidxl wrote:
> The #if 0 needs to be cleaned up.
Oh that was when I was debugging! Sorry about that.


================
Comment at: test/profile/instrprof-order-file.test:4
+//
+// RUN: %clang -forder-file-instrumentation -O1 -o %t.2 %S/Inputs/instrprof-order-file-2.c %S/Inputs/instrprof-order-file.c -mllvm -orderfile-write-mapping="mapping.txt"
+// RUN: %run %t.2 ANY
----------------
davidxl wrote:
> is this option -forder-file-instrumentation already available in clang?
This is in a separate diff (D58751) :]


================
Comment at: test/profile/instrprof-order-file.test:6
+// RUN: %run %t.2 ANY
+// RUN: od -h default.profraw.order | FileCheck %s
+// RUN: cat mapping.txt | FileCheck %s --check-prefix=MAPPING
----------------
davidxl wrote:
> is 'od' portable? maybe exclude it for windows?
Good point!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57530/new/

https://reviews.llvm.org/D57530