[PATCH] D58753: [NFC][Sanitizer] Make GetStackTrace a private method of BufferedStackTrace
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 28 17:24:48 PST 2019
vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.
LGTM, I asked exactly this in another review :)
================
Comment at: compiler-rt/lib/asan/asan_stack.cc:31
-void __sanitizer::GetStackTrace(BufferedStackTrace *stack, uptr max_depth,
- uptr pc, uptr bp, void *context, bool fast) {
+void __sanitizer::BufferedStackTrace::UnwindRuntime(
+ uptr pc, uptr bp, void *context, bool request_fast, u32 max_depth) {
----------------
I don't understand meaning of Runtime here.
Maybe UnwindRuntime -> UnwindImpl
Final decision is up to you
if you prefere Runtime, maybe UnwindByRuntime?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58753/new/
https://reviews.llvm.org/D58753
More information about the llvm-commits
mailing list