[PATCH] D58799: [WebAssembly] Fix crash when @llvm.global_dtors is external

[Thomas Lively via Phabricator via llvm-commits]

tlively created this revision.
tlively added a reviewer: aheejin.
Herald added subscribers: llvm-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D58799

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp
  llvm/test/CodeGen/WebAssembly/global_dtors.ll


Index: llvm/test/CodeGen/WebAssembly/global_dtors.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/WebAssembly/global_dtors.ll
@@ -0,0 +1,9 @@
+; RUN: llc < %s
+
+target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
+target triple = "wasm32-unknown-unknown"
+
+; Check that we do not crash when attempting to lower away
+; global_dtors without a definition.
+
+ at llvm.global_dtors = external global [2 x { i32, void ()*, i8* }]
Index: llvm/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp
===================================================================
--- llvm/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp
+++ llvm/lib/Target/WebAssembly/WebAssemblyLowerGlobalDtors.cpp
@@ -61,7 +61,7 @@
   LLVM_DEBUG(dbgs() << "********** Lower Global Destructors **********\n");
 
   GlobalVariable *GV = M.getGlobalVariable("llvm.global_dtors");
-  if (!GV)
+  if (!GV || !GV->hasInitializer())
     return false;
 
   const ConstantArray *InitList = dyn_cast<ConstantArray>(GV->getInitializer());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58799.188804.patch
Type: text/x-patch
Size: 1065 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190301/21ca5370/attachment.bin>