[PATCH] D58750: [DWARF] Make -g with empty assembler source work better.
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 28 15:56:23 PST 2019
dblaikie added inline comments.
================
Comment at: llvm/lib/MC/MCContext.cpp:586
+ if (FileName.consume_front(getCompilationDir()))
+ (void)FileName.consume_front(llvm::sys::path::get_separator());
+ assert(!FileName.empty());
----------------
No need for the "(void)" here - this function isn't marked NO_DISCARD or anything liek that, by the looks of it?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58750/new/
https://reviews.llvm.org/D58750
More information about the llvm-commits
mailing list