[PATCH] D58250: [AIX][CMake] Changes for building on AIX with XL and GCC

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 15:06:26 PST 2019


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:139
+  if(NOT LLVM_BUILD_32_BITS)
+    if (CMAKE_CXX_COMPILER_ID STREQUAL "XL")
+      append("-q64" CMAKE_CXX_FLAGS CMAKE_C_FLAGS)
----------------
For this and other instances of `STREQUAL "XL"`, we should use `MATCHES "XL"` so that "XLClang" is also matched. See https://gitlab.kitware.com/cmake/cmake/merge_requests/2921.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58250/new/

https://reviews.llvm.org/D58250





More information about the llvm-commits mailing list