[PATCH] D58660: [WebAssembly] Add support for data sections in the assembler.

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel marked 8 inline comments as done.
aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:656
+      if (CurrentState != DataSection) {
+        // Start section
+      }
----------------
sbc100 wrote:
> What will happen now if we hit this case?  Should we assert/unreachable?
Forgot I needed to fill that in. Now errors if not in a data section.


================
Comment at: test/MC/WebAssembly/basic-assembly.s:173
+# CHECK-NEXT:	.int8	72
+# CHECK-NEXT:	.asciz	"ello, World!"
+
----------------
sbc100 wrote:
> To these end up as two different fragments with in the data section?  Just curious how this is preserved through mc.
I'm not entirely sure, as I am still foggy on how fragments work. It does end up adjacent in the binary, which is what matters?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58660/new/

https://reviews.llvm.org/D58660