[llvm] r355135 - [AArch64] [Windows] Fix llvm-readobj -unwind output with many epilogs.

[Eli Friedman via llvm-commits]

Author: efriedma
Date: Thu Feb 28 12:33:22 2019
New Revision: 355135

URL: http://llvm.org/viewvc/llvm-project?rev=355135&view=rev
Log:
[AArch64] [Windows] Fix llvm-readobj -unwind output with many epilogs.

The number of epilog scopes may not fit into a uint8_t.

Fixes https://bugs.llvm.org/show_bug.cgi?id=40855

Differential Revision: https://reviews.llvm.org/D58693


Added:
    llvm/trunk/test/tools/llvm-readobj/arm64-many-epilogs.s
Modified:
    llvm/trunk/include/llvm/Support/ARMWinEH.h

Modified: llvm/trunk/include/llvm/Support/ARMWinEH.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/ARMWinEH.h?rev=355135&r1=355134&r2=355135&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/ARMWinEH.h (original)
+++ llvm/trunk/include/llvm/Support/ARMWinEH.h Thu Feb 28 12:33:22 2019
@@ -382,7 +382,7 @@ struct ExceptionDataRecord {
     return ((Data[0] & 0x00400000) >> 22);
   }
 
-  uint8_t EpilogueCount() const {
+  uint16_t EpilogueCount() const {
     if (HeaderWords(*this) == 1) {
       if (isAArch64)
         return (Data[0] & 0x07C00000) >> 22;

Added: llvm/trunk/test/tools/llvm-readobj/arm64-many-epilogs.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-readobj/arm64-many-epilogs.s?rev=355135&view=auto
==============================================================================
--- llvm/trunk/test/tools/llvm-readobj/arm64-many-epilogs.s (added)
+++ llvm/trunk/test/tools/llvm-readobj/arm64-many-epilogs.s Thu Feb 28 12:33:22 2019
@@ -0,0 +1,26 @@
+// REQUIRES: aarch64-registered-target
+// RUN: llvm-mc -filetype=obj -triple aarch64-windows %s -o - \
+// RUN:   | not llvm-readobj -unwind - | FileCheck %s
+
+// Older versions of LLVM had a bug where we would accidentally
+// truncate the number of epilogue scopes to a uint8_t; make
+// sure this doesn't happen.
+//
+// We expect the llvm-readobj invocation to fail because the
+// xdata section is truncated (to reduce the size of the testcase).
+
+// CHECK: EpilogueScopes: 256
+
+.section .pdata,"dr"
+        .long "?func@@YAHXZ"@IMGREL
+        .long "$unwind$func@@YAHXZ"@IMGREL
+
+        .text
+        .globl  "?func@@YAHXZ"
+        .p2align        3
+"?func@@YAHXZ":
+        ret
+
+.section        .xdata,"dr"
+"$unwind$func@@YAHXZ":
+.long 0x00000000, 0x02010100, 0x09000000, 0x0A000000