[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

[Anton Afanasyev via Phabricator via llvm-commits]

anton-afanasyev marked 3 inline comments as done.
anton-afanasyev added a comment.

Ok, I'm to add tests and reviewers.



================
Comment at: clang/lib/Sema/Sema.cpp:113
+          llvm::TimeTraceProfilerEnd();
+        }
         S->DiagnoseNonDefaultPragmaPack(
----------------
RKSimon wrote:
> remove braces
Ok


================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:23
 #include "clang/Sema/Lookup.h"
+#include "clang/Sema/SemaInternal.h"
 #include "clang/Sema/Template.h"
----------------
RKSimon wrote:
> nfc change?
What do you mean? This change is not NFC.


================
Comment at: clang/tools/driver/cc1_main.cpp:201
+    llvm::TimeTraceProfilerInitialize();
+  }
+
----------------
RKSimon wrote:
> remove braces
Ok


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58675/new/

https://reviews.llvm.org/D58675