[PATCH] D58633: [InstCombine] remove one-use restriction for icmp+add constant fold

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 11:46:33 PST 2019


dmgreen added a comment.

This is another one from cmsis dsp (https://github.com/ARM-software/CMSIS_5/blob/develop/CMSIS/DSP/Source/MatrixFunctions/arm_mat_trans_q31.c). Apparently the original was 20% slower on a thumb1 target, but something daft is likely going on there, as it can sometimes make bad decisions.
https://reviews.llvm.org/P8130
There does look like there's some extra uxth's in there, I've not looked into why. I was compiling with something like "-target arm-arm-none-eabi -mcpu=cortex-m33 -O3" (or maybe m23 for the thumb1 case).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58633/new/

https://reviews.llvm.org/D58633





More information about the llvm-commits mailing list