[llvm] r355114 - [dsymutil] Use rfind for paths with parentheses

[Jonas Devlieghere via llvm-commits]

Author: jdevlieghere
Date: Thu Feb 28 10:46:04 2019
New Revision: 355114

URL: http://llvm.org/viewvc/llvm-project?rev=355114&view=rev
Log:
[dsymutil] Use rfind for paths with parentheses

Dsymutil gets library member information is through the ambiguous
/path/to/archive.a(member.o). The current logic we use would get
confused by additional parentheses. Using rfind mitigates this issue.

Modified:
    llvm/trunk/tools/dsymutil/BinaryHolder.cpp

Modified: llvm/trunk/tools/dsymutil/BinaryHolder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/BinaryHolder.cpp?rev=355114&r1=355113&r2=355114&view=diff
==============================================================================
--- llvm/trunk/tools/dsymutil/BinaryHolder.cpp (original)
+++ llvm/trunk/tools/dsymutil/BinaryHolder.cpp Thu Feb 28 10:46:04 2019
@@ -21,7 +21,7 @@ namespace dsymutil {
 
 static std::pair<StringRef, StringRef>
 getArchiveAndObjectName(StringRef Filename) {
-  StringRef Archive = Filename.substr(0, Filename.find('('));
+  StringRef Archive = Filename.substr(0, Filename.rfind('('));
   StringRef Object = Filename.substr(Archive.size() + 1).drop_back();
   return {Archive, Object};
 }