[PATCH] D58767: [compiler-rt] [CMake] Check for llvm_replace_compiler_option before using it

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 10:41:43 PST 2019


mstorsjo added a comment.

In D58767#1413871 <https://reviews.llvm.org/D58767#1413871>, @rnk wrote:

> I'd prefer to keep the same /Zi vs. /Z7 setting in the standalone build. Does the standalone build not have access to the installed LLVM cmake modules?


It can be built both with and without the LLVM cmake modules. In this particular case, the cmake modules should have been available though.

> If so, I would think we could include them. Or, we could put in a basic regex here like we used to have for -DNDEBUG.

Ok, I'll see if I can find how that was done.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58767/new/

https://reviews.llvm.org/D58767





More information about the llvm-commits mailing list