[PATCH] D58787: [ProfileData] Sort ProfilingData by hash
    Mandeep Singh Grang via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Feb 28 10:38:23 PST 2019
    
    
  
mgrang added inline comments.
================
Comment at: llvm/include/llvm/ProfileData/InstrProfWriter.h:36
 public:
-  using ProfilingData = SmallDenseMap<uint64_t, InstrProfRecord>;
+  using ProfilingData = std::map<uint64_t, InstrProfRecord>;
   enum ProfKind { PF_Unknown = 0, PF_FE, PF_IRLevel };
----------------
I think llvm prefers not to rely on external/STL containers. I would use a MapVector here.
Repository:
  rL LLVM
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58787/new/
https://reviews.llvm.org/D58787
    
    
More information about the llvm-commits
mailing list