[PATCH] D58651: [NFC][Sanitizer] Pull up GetStackTrace into sanitizer_common

[Julian Lettner via Phabricator via llvm-commits]

yln added a comment.

> You can achieve the same affect with weak aliases, `#pragma comment(linker, "/alternatename:foo=foo_default")`, but it is not directly functionally equivalent to weak functions. If you search around for that pragma you should be able to find the code pattern you need.

Thanks!

> You have activated the sanitizer trap card, attempting to use weak functions in portable code.
>  I wish the sanitizers would use fewer weak functions so that we didn't experience this pain every time a new one is introduced.

I totally agree. This is a clear dependency violation (sanitizer_common -> asan, ubsan, ...). In my defense: this was present before (the implementation code is copy & pasted 5 times), but having it declared in sanitizer_common header "exposed" it.

The end goal of my refactoring is to either unify the implementation and pull it up into sanitizer_common or, if that is not possible, at least break the dependency violation (callback, templates?).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58651/new/

https://reviews.llvm.org/D58651