[PATCH] D58705: [X86] Don't peek through bitcasts before checking ISD::isBuildVectorOfConstantSDNodes in combineTruncatedArithmetic

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 09:13:02 PST 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:38719
 
     // See if this is a single use constant which can be constant folded.
+    return ISD::isBuildVectorOfConstantSDNodes(Op.getNode());
----------------
Please add to this comment to make it explicit that we're not peeking through bitcast to avoid fighting with another transform.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58705/new/

https://reviews.llvm.org/D58705





More information about the llvm-commits mailing list