[PATCH] D58787: [ProfileData] Sort ProfilingData by hash

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 08:52:45 PST 2019


lebedev.ri added a reviewer: mgrang.
lebedev.ri added a comment.

This does look better than the D58385 <https://reviews.llvm.org/D58385>.
But i wonder if this is //too// strict and is notably slower?
Have you considered only imposing the ordering/sorting where it matters,
i.e. i think where `FunctionData` is used in `InstrProfWriter::writeImpl()` and `InstrProfWriter::writeText()`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58787/new/

https://reviews.llvm.org/D58787





More information about the llvm-commits mailing list