[PATCH] D58779: [yaml2obj] - Allow setting custom sh_info for RawContentSection sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/yaml2obj/elf-symtab-shinfo.yaml:45
+
+## Check we dont crash when .symtab has type different from SHT_SYMTAB.
+# RUN: yaml2obj -docnum=2 %s -o /dev/null
----------------
This looks like it belongs in a different test, as it's not to do with the sh_info field.


================
Comment at: tools/yaml2obj/yaml2elf.cpp:347
+      IsStatic ? getDotSymTabSecNo() - 1 : getDotDynSymSecNo() - 1;
+  // If symbol table section is explicitly described in the YAML
+  // then we want to be able to set the fields requested.
----------------
If -> If the


================
Comment at: tools/yaml2obj/yaml2elf.cpp:348
+  // If symbol table section is explicitly described in the YAML
+  // then we want to be able to set the fields requested.
+  if (SecNdx < Doc.Sections.size()) {
----------------
want to be able to -> should


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58779/new/

https://reviews.llvm.org/D58779