[PATCH] D58771: [llvm-readobj]Add test showing behaviour of thin archive member path printing

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/llvm-readobj/thin-archive-paths.test:19
+# RUN: not llvm-readelf --file-headers a/relative.a 2>&1 | FileCheck %s --check-prefix=ERR1
+# ERR1: Error reading file: a/relative.a: 'b/1.o': {{[Nn]}}o such file or directory
+
----------------
jhenderson wrote:
> grimar wrote:
> > grimar wrote:
> > > I hope this will this work under both linux and windows (I am not sure).
> > > I guess you might need to use:
> > > ```
> > > Error reading file: a{{/|\\}}relative.a
> > > ```
> > On second thought, I guess the archive should not contain the windows style slashes.
> Actually, the archive contains whatever slash is on the command-line when adding the member. In this case, it will be '/' even on Windows. The full path below will have a mixture of '/' and '\' on Windows. llvm-readobj then just prints what's in the archive.
> 
> BTW, I did this all on Windows, so it definitely works on there.
OK, great, thanks for the explanation!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58771/new/

https://reviews.llvm.org/D58771