[PATCH] D58651: [NFC][Sanitizer] Pull up GetStackTrace into sanitizer_common

Thu Feb 28 02:18:38 PST 2019

mstorsjo added subscribers: rnk, mstorsjo.
mstorsjo added a comment.

+ @rnk

It turns out that the fix for Windows in rL355052 <https://reviews.llvm.org/rL355052> didn't turn out to help either: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/42624/steps/stage%201%20build/logs/stdio

FWIW, on MinGW, this didn't break compilation like on MSVC, but linking still fails because SANITIZER_WEAK_ATTRIBUTE (as part of SANITIZER_WEAK_CXX_DEFAULT_IMPL) is empty for windows. (For MinGW, GCC does support `__attribute__((weak))`, but that isn't implemented in clang/llvm.)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58651/new/

https://reviews.llvm.org/D58651