[PATCH] D58762: [BinaryFormat] Add DT_USED tag into dynamic section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 02:18:36 PST 2019


grimar added a comment.

In D58762#1413307 <https://reviews.llvm.org/D58762#1413307>, @jhenderson wrote:

> In D58762#1413306 <https://reviews.llvm.org/D58762#1413306>, @grimar wrote:
>
> > FWIW DT_AUXILIARY and DT_FILTER are supported by LLD.
>
>
> Yes, hence why I'm less fussed about those. We already support them in other parts of LLVM, but we don't DT_USED, right?


AFAIK - yes. It might be a good idea to support in in readelf though. If somebody one day will want to use its value for something, he/she
be able to find out that the flag is already used. At least in the code in the wild. I think it's better to try not to reuse the existent values.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58762/new/

https://reviews.llvm.org/D58762





More information about the llvm-commits mailing list