[lld] r355075 - [LLD][ELF] - Stop using binary input in invalid/tls-symbol.s test. NFCI.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 01:24:13 PST 2019


Author: grimar
Date: Thu Feb 28 01:24:12 2019
New Revision: 355075

URL: http://llvm.org/viewvc/llvm-project?rev=355075&view=rev
Log:
[LLD][ELF] - Stop using binary input in invalid/tls-symbol.s test. NFCI.

We can use yaml2obj instead, patch does this.

Removed:
    lld/trunk/test/ELF/invalid/Inputs/tls-symbol.elf
Modified:
    lld/trunk/test/ELF/invalid/tls-symbol.s

Removed: lld/trunk/test/ELF/invalid/Inputs/tls-symbol.elf
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/Inputs/tls-symbol.elf?rev=355074&view=auto
==============================================================================
Binary file - no diff available.

Modified: lld/trunk/test/ELF/invalid/tls-symbol.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/invalid/tls-symbol.s?rev=355075&r1=355074&r2=355075&view=diff
==============================================================================
--- lld/trunk/test/ELF/invalid/tls-symbol.s (original)
+++ lld/trunk/test/ELF/invalid/tls-symbol.s Thu Feb 28 01:24:12 2019
@@ -1,5 +1,24 @@
-# REQUIRES: x86
-
 ## The test file contains an STT_TLS symbol but has no TLS section.
-# RUN: not ld.lld %S/Inputs/tls-symbol.elf -o /dev/null 2>&1 | FileCheck %s
+## Check we report an error properly.
+
+# RUN: yaml2obj %s -o %t.o
+# RUN: not ld.lld %t.o -o /dev/null 2>&1 | FileCheck %s
+
 # CHECK: has an STT_TLS symbol but doesn't have an SHF_TLS section
+
+--- !ELF
+FileHeader:      
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  Type:            ET_REL
+  Machine:         EM_X86_64
+Sections:        
+  - Name:            .text
+    Type:            SHT_PROGBITS
+    Flags:           [ SHF_ALLOC, SHF_EXECINSTR ]
+    Content:         ''
+Symbols:
+  Global:
+    - Name:            bar
+      Type:            STT_TLS
+      Section:         .text




More information about the llvm-commits mailing list