[PATCH] D58762: [BinaryFormat] Add DT_USED tag into dynamic section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 28 00:40:10 PST 2019


grimar added a comment.

LGTM, but please wait for @jhenderson approvement just in case.
(at first, I was wondering if it should be placed to `dynamic-section-arch-tags.test` instead since these flags seem
to be sun specific extensions. I think dynamic-section.test is fine, because in DynamicTags.def we handle them as common tags).

Side note: we do not test DT_AUXILIARY and DT_FILTER. We might want to fix it for yaml2obj/ob2yaml too.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58762/new/

https://reviews.llvm.org/D58762





More information about the llvm-commits mailing list