[PATCH] D58750: [DWARF] Make -g with empty assembler source work better.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 17:37:59 PST 2019


aprantl added inline comments.


================
Comment at: clang/tools/driver/cc1as_main.cpp:336
+  // We may need this handle later.
+  StringRef BufferRef = Buffer->get()->getBuffer();
 
----------------
Why not move this to line 411?


================
Comment at: llvm/lib/MC/MCDwarf.cpp:1018
+          ? context.getMCDwarfLineTable(/*CUID=*/0).getRootFile()
+          : MCDwarfFiles[1];
+  MCOS->EmitBytes(RootFile.Name);
----------------
Are there guaranteed to be >1 MCDwarfFiles?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58750/new/

https://reviews.llvm.org/D58750





More information about the llvm-commits mailing list