[PATCH] D58534: dsymutil support for DW_OP_convert

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 17:07:12 PST 2019


aprantl marked an inline comment as done.
aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:1071
+
+    if ((Op0 == Encoding::BaseTypeRef && Op1 == Encoding::SizeNA) ||
+        (Op1 == Encoding::BaseTypeRef && Op0 == Encoding::Size1)) {
----------------
JDevlieghere wrote:
> Can we invert this and do a continue?
No, there is an else path, too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58534/new/

https://reviews.llvm.org/D58534





More information about the llvm-commits mailing list