[PATCH] D58636: [BinaryFormat] Update Mach-O ARM64 CPU subtypes and dumping

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

Of the code additions in this change, I'm only adding a test for one block, because that was the only block I could find related tests for. I'm happy to add tests for the other code blocks for my specific changes, but I don't have the bandwidth to improve the general coverage for them right now.

Note that Apple's objdump (from Xcode 10.1) does print a symbolic subtype for arm64e but not for arm64_v8 (it just prints the numeric subtype there). I don't know if arm64_v8 is actually used for anything right now, and I'm happy to limit this change to just arm64e if Apple prefers.

There's one other block that references CPU_SUBTYPE_ARM64_ALL that I haven't updated, because I don't know what the appropriate values for the new subtypes should be: https://github.com/llvm/llvm-project/blob/95bb3c3cc3f74d2448e6a495c6989f988c24770c/llvm/lib/Object/MachOObjectFile.cpp#L2628


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58636/new/

https://reviews.llvm.org/D58636