[compiler-rt] r355052 - [NFC][Sanitizer] Use correct WEAK annotation to make Windows work

Julian Lettner via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 16:43:40 PST 2019


Author: yln
Date: Wed Feb 27 16:43:40 2019
New Revision: 355052

URL: http://llvm.org/viewvc/llvm-project?rev=355052&view=rev
Log:
[NFC][Sanitizer] Use correct WEAK annotation to make Windows work

The previous fix didn't work for Windows:
https://github.com/llvm/llvm-project/commit/52b751088b11547e0f4ef0589ebbe5e57752c68c

Modified:
    compiler-rt/trunk/lib/ubsan/ubsan_diag.cc

Modified: compiler-rt/trunk/lib/ubsan/ubsan_diag.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/ubsan/ubsan_diag.cc?rev=355052&r1=355051&r2=355052&view=diff
==============================================================================
--- compiler-rt/trunk/lib/ubsan/ubsan_diag.cc (original)
+++ compiler-rt/trunk/lib/ubsan/ubsan_diag.cc Wed Feb 27 16:43:40 2019
@@ -28,7 +28,7 @@ using namespace __ubsan;
 
 // Weak linkage: UBSan is combined with runtimes that already provide this
 // functionality (e.g., ASan) as well as runtimes that lack it (e.g., scudo).
-SANITIZER_WEAK_ATTRIBUTE
+SANITIZER_WEAK_CXX_DEFAULT_IMPL
 void __sanitizer::GetStackTrace(BufferedStackTrace *stack, uptr max_depth,
                                 uptr pc, uptr bp, void *context, bool fast) {
   uptr top = 0;




More information about the llvm-commits mailing list