[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 15:30:57 PST 2019


sbc100 added a comment.

I think I like this.

We may find a reason down the line to allow passive to be set per-segment, but now keeping it simple and lettings the linker decide makes sense.



================
Comment at: llvm/test/CodeGen/WebAssembly/atomic-mem-consistency.ll:1
-; RUN: not llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
+; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
 ; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -wasm-disable-explicit-locals -wasm-keep-registers -mattr=+atomics,+sign-ext | FileCheck %s
----------------
What did this start passing?   Is it because llc now has the correct default and will lower atomics to non-atomics?  I guess there is no longer a way to make this fail in the way that it did before.. which is good?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58742/new/

https://reviews.llvm.org/D58742





More information about the llvm-commits mailing list