[PATCH] D58739: [COFF] Add address-taken import thunks to the fid table

[Reid Kleckner via Phabricator via llvm-commits]

rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: lld/test/COFF/guardcf-thunk.s:28
+        .section .text,"rx"
+        .def     main; .scl    2; .type   32; .endef
+        .global main
----------------
I think `IMAGE_SYM_DTYPE_FUNCTION` is set by the .type directive in this .def/.endef block. I guess what we're doing doesn't match MSVC, but it also seems reasonable. Is the Rust function written in assembly, or is it emitted in LLVM? We should be setting the appropriate type...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58739/new/

https://reviews.llvm.org/D58739