[PATCH] D58554: GlobalISel: Implement moreElementsVector for phi

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 15:01:32 PST 2019


paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM aside from nit



================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:2389
+  Observer.changingInstr(MI);
+  for (unsigned I = 1; I < MI.getNumOperands(); I += 2) {
+    MachineBasicBlock &OpMBB = *MI.getOperand(I + 1).getMBB();
----------------
`for (unsigned I = 1, E = MI.getNumOperands(); I < E; I += 2)`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58554/new/

https://reviews.llvm.org/D58554





More information about the llvm-commits mailing list