[PATCH] D58184: [scudo][standalone] Introduce platform specific code & mutexes

Wed Feb 27 12:29:06 PST 2019

brzycki added a comment.

@cryptoad the following (terribly hacky) patch successfully builds for me on Ubuntu 18.04 LTS:

  diff --git a/compiler-rt/cmake/base-config-ix.cmake b/compiler-rt/cmake/base-config-ix.cmake
  index ee9426b715d..8cc1e922f50 100644
  --- a/compiler-rt/cmake/base-config-ix.cmake
  +++ b/compiler-rt/cmake/base-config-ix.cmake
  @@ -161,7 +161,7 @@ macro(test_targets)
             endif()
           else()
             test_target_arch(x86_64 "" "-m64")
  -          test_target_arch(i386 __i386__ "-m32")
  +          #test_target_arch(i386 __i386__ "-m32")
           endif()
         else()
           if (CMAKE_SIZEOF_VOID_P EQUAL 4)

I'm about to test it on RHEL 6.7 to see if the two are orthogonal or related (I suspect the former).

It's interesting you have no problems building i386. For reference here is my cmake configuration line:

  cmake -G Ninja  -D CMAKE_C_COMPILER=/usr/bin/clang-6.0 -D CMAKE_CXX_COMPILER=/usr/bin/clang++-6.0 -D CMAKE_BUILD_TYPE=Debug -D CMAKE_INSTALL_PREFIX=/work/b.rzycki/upstream/install -D LLVM_TOOL_CLANG_BUILD=ON -D LIBCXX_INCLUDE_BENCHMARKS=ON -D BUILD_SHARED_LIBS=ON -D LLVM_ENABLE_ASSERTIONS=ON  -D LLVM_TARGETS_TO_BUILD=X86 /work/b.rzycki/upstream/llvm-project/llvm

Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58184/new/

https://reviews.llvm.org/D58184