[PATCH] D58723: [scudo][standalone] Add bytemap classes
Matt Morehouse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 27 11:22:23 PST 2019
morehouse added inline comments.
================
Comment at: lib/scudo/standalone/bytemap.h:22
+ Map = reinterpret_cast<u8 *>(map(nullptr, Size, "scudo:bytemap"));
+ }
+ void init() { initLinkerInitialized(); }
----------------
Having two init functions is a little confusing. Would it make more sense to have a constexpr constructor and a single init() function?
================
Comment at: lib/scudo/standalone/tests/bytemap_test.cc:14
+#include <string.h>
+
+TEST(ScudoByteMapTest, TwoLevelByteMap) {
----------------
Tests for `FlatByteMap`?
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58723/new/
https://reviews.llvm.org/D58723
More information about the llvm-commits
mailing list